WaitForActivation optimizations #5396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…waitforactivation
…waitforactivation
…nto waitforactivation
…waitforactivation
Codecov Report
@@ Coverage Diff @@
## master #5396 +/- ##
=======================================
Coverage 19.00% 19.00%
=======================================
Files 238 238
Lines 20323 20323
=======================================
Hits 3862 3862
Misses 15866 15866
Partials 595 595 |
…nto waitforactivation
…waitforactivation
0xKiwi
commented
Apr 14, 2020
| depositsLock sync.RWMutex | ||
| chainStartDeposits []*ethpb.Deposit | ||
| chainstartPubkeys map[string]bool | ||
| chainstartPubkeysLock sync.RWMutex |
There was a problem hiding this comment.
Removing because the only calling function already has a lock.
0xKiwi
changed the title
0xKiwi
changed the title
shayzluf
reviewed
Apr 15, 2020
…waitforactivation
nisdas
approved these changes
Apr 19, 2020
prestonvanloon
approved these changes
Apr 20, 2020
This was referenced Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5268, this PR completes the beacon node server side of WaitForActivation improvements, removing the unneeded Eth1 RPC calls for active validators.
Also modifies what roles are what to improve UX, notably the UNKOWN and DEPOSITED statuses show much more useful information than they used to.
Contains minor validator changes, mainly testing.